[DPE-9315] add user-provided private key#20
Merged
Conversation
…al secret-change to be performed before checking password-update
skourta
approved these changes
Mar 12, 2026
Contributor
skourta
left a comment
skourta
left a comment
There was a problem hiding this comment.
Amazing work @reneradoi. No concerns from my part. The implementation is identical to the one we have and hardened on etcd.
# Conflicts: # src/events/tls.py # src/managers/tls.py # src/statuses.py # tests/integration/tls/test_certificate_rotation.py # tests/unit/test_tls.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functionality + tests for having a private key for client certificates provided by users. The private key is added as a user secret and the secret URI configured to the charm. If the provided private key is invalid or the charm has no access, the previously used private key will be maintained.